chore(coreutils): revert mv, cp, rm to gnu coreutils#316
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies elements/bluefin/uutils-coreutils.bst to exclude cp, mv, and rm from being symlinked to uutils-coreutils due to TOCTOU security vulnerabilities. The review feedback suggests moving the exclusion logic to the beginning of the loop to also prevent the creation of uutils- prefixed symlinks for these tools, ensuring they are not exposed in the final image.
castrojo
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://discourse.ubuntu.com/t/an-update-on-rust-coreutils/80773
We should make sure the default in https://github.com/projectbluefin/dakota for cp, mv, and rm are from GNU coreutils
Closes projectbluefin/common#290
Did a sanity on my local build: