Skip to content

chore(coreutils): revert mv, cp, rm to gnu coreutils#316

Merged
castrojo merged 1 commit intomainfrom
chore/mv-cp-rm-from-gnu-coreutils
Apr 22, 2026
Merged

chore(coreutils): revert mv, cp, rm to gnu coreutils#316
castrojo merged 1 commit intomainfrom
chore/mv-cp-rm-from-gnu-coreutils

Conversation

@ahmedadan
Copy link
Copy Markdown
Collaborator

@ahmedadan ahmedadan commented Apr 22, 2026

As per https://discourse.ubuntu.com/t/an-update-on-rust-coreutils/80773

cp, mv, and rm continue to be provided by GNU coreutils in 26.04. These utilities have remaining open TOCTOU (time-of-check to time-of-use) issues (8 as of Apr 22, 2026) that need to be resolved before we are confident shipping them.

We should make sure the default in https://github.com/projectbluefin/dakota for cp, mv, and rm are from GNU coreutils

Closes projectbluefin/common#290

Did a sanity on my local build:

=== unprefixed cp/mv/rm must be GNU ===
/usr/bin/cp -> /usr/bin/cp
  version: cp (GNU coreutils) 9.7
/usr/bin/mv -> /usr/bin/mv
  version: mv (GNU coreutils) 9.7
/usr/bin/rm -> /usr/bin/rm
  version: rm (GNU coreutils) 9.7

=== uutils- prefixed aliases must still exist and be uutils ===
/usr/bin/uutils-cp -> uutils-coreutils
  version: cp (uutils coreutils) 0.8.0
/usr/bin/uutils-mv -> uutils-coreutils
  version: mv (uutils coreutils) 0.8.0
/usr/bin/uutils-rm -> uutils-coreutils
  version: rm (uutils coreutils) 0.8.0

=== sanity: other applets still default to uutils ===
/usr/bin/ls -> /usr/bin/uutils-coreutils
/usr/bin/cat -> /usr/bin/uutils-coreutils
/usr/bin/chmod -> /usr/bin/uutils-coreutils

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies elements/bluefin/uutils-coreutils.bst to exclude cp, mv, and rm from being symlinked to uutils-coreutils due to TOCTOU security vulnerabilities. The review feedback suggests moving the exclusion logic to the beginning of the loop to also prevent the creation of uutils- prefixed symlinks for these tools, ensuring they are not exposed in the final image.

Comment thread elements/bluefin/uutils-coreutils.bst
@castrojo castrojo enabled auto-merge April 22, 2026 20:58
@castrojo castrojo added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit b0e8beb Apr 22, 2026
3 checks passed
@castrojo castrojo deleted the chore/mv-cp-rm-from-gnu-coreutils branch April 22, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keep cp, mv, and rm from GNU coreutils

2 participants