fix(ci): suppress phantom PRs when bst source track only normalizes r…#317
Merged
castrojo merged 1 commit intoprojectbluefin:mainfrom Apr 22, 2026
Merged
Conversation
…ef format bst source track rewrites plain SHA refs to git-describe format (e.g. 965cd7b9... -> v0.2.13-0-g965cd7b9...) even when the underlying commit has not changed. This caused the daily bot to open PRs like projectbluefin#312 and projectbluefin#311 where old and new SHAs were identical. Fix: after detecting a git diff, compare the set of terminal 40-char hex SHAs extracted from ref: lines in the old file state (HEAD) vs the new (working tree). If the sets are identical and non-empty, it is a format-only normalization — set has_changes=false and skip PR creation. Using file-state comparison (not diff-hunk parsing) correctly handles multi-ref elements such as common.bst (git_repo + git_module). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Assisted-by: Claude Sonnet 4.6 via GitHub Copilot
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ef format
bst source track rewrites plain SHA refs to git-describe format (e.g. 965cd7b9... -> v0.2.13-0-g965cd7b9...) even when the underlying commit has not changed. This caused the daily bot to open PRs like #312 and #311 where old and new SHAs were identical.
Fix: after detecting a git diff, compare the set of terminal 40-char hex SHAs extracted from ref: lines in the old file state (HEAD) vs the new (working tree). If the sets are identical and non-empty, it is a format-only normalization — set has_changes=false and skip PR creation.
Using file-state comparison (not diff-hunk parsing) correctly handles multi-ref elements such as common.bst (git_repo + git_module).
Assisted-by: Claude Sonnet 4.6 via GitHub Copilot