fix(renovate): include sha256: prefix in chunkah currentDigest capture#323
Conversation
Renovate's Docker datasource requires currentDigest to include the 'sha256:' prefix. The previous regex stripped it, causing Renovate to silently discard the match without adding chunkah to detected dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration for the chunkah dependency to include the sha256: prefix within the currentDigest capture group. The reviewer identified a critical issue where the regex is missing the assignment operator (=), which would prevent it from matching the intended lines in the Justfile, and provided a more robust suggestion that handles optional whitespace.
| ], | ||
| "matchStrings": [ | ||
| "CHUNKAH_REF=\"(?<depName>quay\\.io/coreos/chunkah)@sha256:(?<currentDigest>[a-f0-9]{64})\"" | ||
| "CHUNKAH_REF=\"(?<depName>quay\\.io/coreos/chunkah)@(?<currentDigest>sha256:[a-f0-9]{64})\"" |
There was a problem hiding this comment.
The fix for the currentDigest capture group correctly includes the sha256: prefix. However, the regex is missing the assignment operator (=) between the variable name and the value, which will prevent it from matching the assignment in the Justfile (e.g., CHUNKAH_REF="..."). Additionally, adding optional whitespace around the operator makes the regex more robust and consistent with other managers in this file.
"CHUNKAH_REF\\s*=\\s*\"(?<depName>quay\\.io/coreos/chunkah)@(?<currentDigest>sha256:[a-f0-9]{64})\""
1 participant
Renovate's Docker datasource requires currentDigest to include the 'sha256:' prefix. The previous regex stripped it, causing Renovate to silently discard the match without adding chunkah to detected dependencies.