Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on re-integrating a crucial image optimization step into the build process and refining how OCI images are handled and referenced. These changes aim to improve the efficiency of image management and ensure consistent image naming conventions across different build targets. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request re-enables the chunkify step in the export recipe. To support this, it adds a podman tag command to correctly tag the image loaded from the BuildStream artifact and updates the boot-fast command to use the new image tag. My review found a critical issue where a necessary cleanup command was removed, which would cause subsequent builds to fail. I've provided a suggestion to re-add it to ensure the build process is repeatable.
|
|
||
| echo "==> Exporting OCI image..." | ||
| rm -rf .build-out | ||
| just bst artifact checkout oci/bluefin.bst --directory /src/.build-out |
There was a problem hiding this comment.
The rm -rf .build-out command was removed, but it is necessary for the bst artifact checkout command, which requires that the output directory does not exist. Without removing .build-out before checkout, this script will fail on any subsequent run after the first successful one. Please add rm -rf .build-out back before this line.
rm -rf .build-out
just bst artifact checkout oci/bluefin.bst --directory /src/.build-out
alatiera
force-pushed
the
alatiera/chunkify
branch
7 times, most recently
from
7a28e27 to
dd5a8e1
Compare
|
This is still broken |
alatiera
force-pushed
the
alatiera/chunkify
branch
from
dd5a8e1 to
79f8a75
Compare
Re-enable the chunkify step that was disabled while debugging. Also fix the podman --mount=type=image syntax: 'dest' is not a valid option name, the correct key is 'dst'. This was the root cause of the 'invalid mount option' error reported in projectbluefin#93. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…yntax Re-enable the chunkify step in export and overhaul the chunkify recipe: - Uncomment `just chunkify` in the export recipe (what projectbluefin#93 intended) - Fix image: quay.io/jlebon/chunkah → quay.io/coreos/chunkah (project moved) - Fix mount: `dest=` is not a valid podman option; use `dst=` (valid aliases: dst/destination/target). Root cause of "invalid mount option" in #93. - Add --max-layers 128: chunkah docs recommend >64 layers for bootc images - Add --prune /sysroot/: exclude OSTree object store from chunking; no-op if absent in this BuildStream-built image, prevents 7s warning on ostree images - Use -t flag (post-v0.3.2): embeds tag in OCI archive so podman load tags automatically; removes the complex NEW_REF parse + podman tag dance Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Enable the chunkah rechunking pipeline validated on ghost: - Uncomment just chunkify call in the export recipe - mktemp -d -p /var/tmp: avoid EPERM xattr writes on tmpfs /tmp - CHUNKAH_ROOTFS=/chunkah: required env var for chunkah rootfs bind mount - --prune /sysroot/: exclude OSTree store from rechunking, eliminates 7s warning - --label ostree.commit- --label ostree.final-diffid-: required for bootc rechunking - --max-layers 120 (was 128): validated layer count for this image - Pre-committed filemap guard: skip gen-filemap when files already present (CI path) - CI push (x86 only): skopeo copy --dest-compress-format=zstd aarch64 job is disabled (if: false); its push step has a TODO comment Avoids zstd:chunked blob cache re-use that breaks plain zstd guarantee with bootc composefs Supersedes draft PR projectbluefin#93. Assisted-by: Claude Sonnet 4.6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
No description provided.