Skip to content

feat: update Bazaar link#579

Open
AsciiWolf wants to merge 1 commit intoprojectbluefin:mainfrom
AsciiWolf:patch-1
Open

feat: update Bazaar link#579
AsciiWolf wants to merge 1 commit intoprojectbluefin:mainfrom
AsciiWolf:patch-1

Conversation

@AsciiWolf
Copy link
Copy Markdown

Use the official homepage instead of GitHub repo.

Same change as: ublue-os/bazzite.gg#59

Use the official homepage instead of GitHub repo
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bazaar app store URL in the English localization file. A security improvement was suggested to include rel="noopener noreferrer" on links using target="_blank" to prevent potential tabnabbing attacks.

Comment thread src/locales/en-US.json
"Tag": "Run your favorite",
"Title": "Applications",
"Description": "Bluefin utilizes the <a href=\"https://github.com/kolunmi/bazaar\" target=\"_blank\">Bazaar</a> app store, allowing for easy installation and management of all your favorite applications from <a href=\"https://flathub.org\" target=\"_blank\">Flathub</a> and a curated list of apps we think you'll love.",
"Description": "Bluefin utilizes the <a href=\"https://usebazaar.org\" target=\"_blank\">Bazaar</a> app store, allowing for easy installation and management of all your favorite applications from <a href=\"https://flathub.org\" target=\"_blank\">Flathub</a> and a curated list of apps we think you'll love.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

When using target="_blank", it is a security best practice to include rel="noopener noreferrer" to prevent potential tabnabbing attacks and protect user privacy. This should be applied to both links in this description.

Suggested change
"Description": "Bluefin utilizes the <a href=\"https://usebazaar.org\" target=\"_blank\">Bazaar</a> app store, allowing for easy installation and management of all your favorite applications from <a href=\"https://flathub.org\" target=\"_blank\">Flathub</a> and a curated list of apps we think you'll love.",
"Description": "Bluefin utilizes the <a href=\"https://usebazaar.org\" target=\"_blank\" rel=\"noopener noreferrer\">Bazaar</a> app store, allowing for easy installation and management of all your favorite applications from <a href=\"https://flathub.org\" target=\"_blank\" rel=\"noopener noreferrer\">Flathub</a> and a curated list of apps we think you'll love.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant