vpp-manager: rebind interfaces to kernel if link is missing#922
Merged
Conversation
hedibouattour
force-pushed
the
bind-interfaces-to-kernel-if-interface-not-found
branch
6 times, most recently
from
be0dc1c to
7ffbe87
Compare
hedibouattour
force-pushed
the
bind-interfaces-to-kernel-if-interface-not-found
branch
2 times, most recently
from
be83081 to
09e852a
Compare
hedibouattour
force-pushed
the
bind-interfaces-to-kernel-if-interface-not-found
branch
from
09e852a to
9fd6fa3
Compare
If VPP is killed abruptly (e.g. due to OOM), it does not shut down gracefully and does not restore interface bindings. As a result, interfaces may remain bound to a DPDK driver and no longer appear as Linux network devices. When the expected interface is not found, attempt to rebind PCI devices back to the kernel driver and retry the lookup once. Because we don't die gracefully, pingCalicoVPP() won't be called and agent will never restart. So we call it in the beginning to kill previous stale agents if any.
hedibouattour
force-pushed
the
bind-interfaces-to-kernel-if-interface-not-found
branch
from
9fd6fa3 to
91531e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If VPP is killed abruptly (e.g. due to OOM), it does not shut down
gracefully and does not restore interface bindings. As a result,
interfaces may remain bound to a DPDK driver and no longer appear
as Linux network devices.
When the expected interface is not found, attempt to rebind PCI
devices back to the kernel driver and retry the lookup once.
Because we don't die gracefully, pingCalicoVPP() won't be called
and agent will never restart. So we call it in the beginning to
kill previous stale agents if any.