Add TranslateUplinkAddrMaskTo64 option only for non LL /128#928
Merged
Conversation
This patch transforms the UplinkSubnetMask option to TranslateUplinkAddrMaskTo64 and restricts it to only apply to non linklocal v6 addresses read on the uplink interface, and that have a /128 prefix With the previous implementation we were trying to program VPP with LL /64 addresses which was returning errors. Also this patch makes it so that vpp-manager will error out if it fails programming VPP with an address so that we notice such errors Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
sknat
force-pushed
the
nsk-TranslateUplinkAddrMaskTo64
branch
from
e9fec56 to
1e8ede9
Compare
hedibouattour
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch transforms the UplinkSubnetMask option to TranslateUplinkAddrMaskTo64 and restricts it to only apply to non linklocal v6 addresses read on the uplink interface, and that have a /128 prefix
With the previous implementation we were trying to program VPP with LL /64 addresses which was returning errors.
Also this patch makes it so that vpp-manager will error out if it fails programming VPP with an address so that we notice such errors