Skip to content

fix: use multi stage docker file #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrabauke merged 1 commit into from
Jan 21, 2026
Merged

fix: use multi stage docker file #2514

derrabauke merged 1 commit into from
Jan 21, 2026

Conversation

@MitanOmar
Copy link
Member

@MitanOmar MitanOmar commented Jan 20, 2026 •
edited
Loading

fixes #2512

@MitanOmar MitanOmar self-assigned this Jan 20, 2026
@MitanOmar MitanOmar added the docker Pull requests that update Docker code label Jan 20, 2026
derrabauke
derrabauke reviewed Jan 21, 2026
View reviewed changes
@MitanOmar MitanOmar force-pushed the use-multi-stage-docker-build branch from 110bba5 to 56e9ce7 Compare January 21, 2026 10:17
c0rydoras
c0rydoras reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

@c0rydoras c0rydoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i'd mark it as fix instead of chore

@MitanOmar MitanOmar force-pushed the use-multi-stage-docker-build branch from 56e9ce7 to 4b76bd7 Compare January 21, 2026 11:33
@derrabauke
Copy link
Contributor

derrabauke commented Jan 21, 2026

also i'd mark it as fix instead of chore

@MitanOmar and mark it as ready if ready for final review pls :-)

@MitanOmar MitanOmar marked this pull request as ready for review January 21, 2026 13:28
@MitanOmar MitanOmar force-pushed the use-multi-stage-docker-build branch from 4b76bd7 to c1c661f Compare January 21, 2026 14:05
@MitanOmar MitanOmar changed the title chore: use multi stage docker file fix: use multi stage docker file Jan 21, 2026
derrabauke
derrabauke approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🎉

@derrabauke derrabauke merged commit e309e8e into main Jan 21, 2026
12 checks passed
@derrabauke derrabauke deleted the use-multi-stage-docker-build branch January 21, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c0rydoras c0rydoras c0rydoras left review comments

@derrabauke derrabauke derrabauke approved these changes

Assignees

@MitanOmar MitanOmar

Labels

docker Pull requests that update Docker code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multi-stage Dockerfile

4 participants

@MitanOmar @derrabauke @c0rydoras