i915: Add media compression support for Gen-12 with feature flag #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Gen-12 onwards Media compression aux buffer layout has been changed. The functionality to allocate minigbm compressed buffers are mostly taken from CL:3275292 and this CL adapts it to guard this feature behind an environment variable controlled by the minigbm user application (we're not re-using the original CL because it seems the original author is no longer active). BUG=b:201620358 TEST=Play video on Chrome with feature flag enabled for MMC and verify type (7) of buffer modifer in the output of below command: localhost ~ # cat /sys/kernel/debug/dri/0/i915_gem_framebuffer user size: 1280 x 720, depth 0, 8 bpp, modifier 0x100000000000007 Tracked-On: OAM-130084 Change-Id: I69cb527eb9d16498f7e9c2fb32c793cea6b6a4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4655427 Reviewed-by: Andres Calderon Jaramillo <andrescj@google.com> Commit-Queue: Hang Nguyen <hnt@chromium.org> Tested-by: Hang Nguyen <hnt@chromium.org> Signed-off-by: chenyanxzhu <chenyanx.zhu@intel.com>
sysopenci
added
Pending Developer Approval
sysopenci
requested review from
YuanjunHuang,
feijiang1,
gkdeepa,
renchenglei,
yaoxinshi-intel and
yyao3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Gen-12 onwards Media compression aux buffer layout has been changed. The functionality to allocate minigbm compressed buffers are mostly taken from CL:3275292 and this CL adapts it to guard this feature behind an environment variable controlled by the minigbm user application (we're not re-using the original CL because it seems the original author is no longer active).
BUG=b:201620358
TEST=Play video on Chrome with feature flag enabled for MMC and verify type (7) of buffer modifer in the output of below command:
localhost ~ # cat /sys/kernel/debug/dri/0/i915_gem_framebuffer user size: 1280 x 720, depth 0, 8 bpp, modifier 0x100000000000007
Tracked-On: OAM-130084
Change-Id: I69cb527eb9d16498f7e9c2fb32c793cea6b6a4ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4655427
Reviewed-by: Andres Calderon Jaramillo andrescj@google.com
Commit-Queue: Hang Nguyen hnt@chromium.org
Tested-by: Hang Nguyen hnt@chromium.org