Skip to content

fix: remove flaky integration tests#534

Merged
ehsandeep merged 1 commit intodevfrom
fix/remove-integration-tests
Feb 25, 2026
Merged

fix: remove flaky integration tests#534
ehsandeep merged 1 commit intodevfrom
fix/remove-integration-tests

Conversation

@dogancanbakir
Copy link
Copy Markdown
Member

Fixes #514

Integration tests fail on PRs because CI secrets (Discord, Slack, Custom webhook URLs) are unavailable in fork/external contexts.

Changes:

  • Removed cmd/integration-test/ and internal/testutils/
  • Removed Gotify service and integration test step from build-test.yml
  • Updated go test to run across all packages (./...)

Unit tests (pkg/providers/smtp/smtp_test.go) are preserved and passing.

Integration tests depend on external service secrets (Discord, Slack,
Custom webhooks) that are unavailable in fork PRs, causing consistent
CI failures. Remove the integration test suite and keep unit tests.

Closes #514
@neo-by-projectdiscovery-dev
Copy link
Copy Markdown

neo-by-projectdiscovery-dev bot commented Feb 25, 2026

Neo - PR Security Review

No security issues found

Highlights

  • Removes integration test directories (cmd/integration-test/, internal/testutils/) that were failing in fork/PR contexts due to unavailable CI secrets
  • Updates build-test.yml workflow to run 'go test ./...' across all packages
  • Preserves unit tests in pkg/providers/smtp/smtp_test.go

Comment @neo help for available commands. · Open in Neo

@dogancanbakir dogancanbakir self-assigned this Feb 25, 2026
@ehsandeep ehsandeep merged commit 992d2b2 into dev Feb 25, 2026
7 checks passed
@ehsandeep ehsandeep deleted the fix/remove-integration-tests branch February 25, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants