Skip to content

chore(deps): bump github.com/shoenig/go-m1cpu to v0.2.1#7328

Closed
bcdlbgm wants to merge 1 commit intoprojectdiscovery:devfrom
bcdlbgm:fix/macos-arm64-startup-crash
Closed

chore(deps): bump github.com/shoenig/go-m1cpu to v0.2.1#7328
bcdlbgm wants to merge 1 commit intoprojectdiscovery:devfrom
bcdlbgm:fix/macos-arm64-startup-crash

Conversation

@bcdlbgm
Copy link
Copy Markdown

@bcdlbgm bcdlbgm commented Apr 5, 2026

Proposed changes

Proof

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

Chores

  • Updated indirect dependencies to latest stable versions for improved system compatibility and performance.

@auto-assign auto-assign bot requested a review from dwisiswant0 April 5, 2026 13:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

Walkthrough

Updated the indirect dependency github.com/shoenig/go-m1cpu in go.mod from version v0.1.6 to v0.2.1. No other module configuration, require entries, or retract directives were modified.

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod
Bumped indirect dependency github.com/shoenig/go-m1cpu from v0.1.6 to v0.2.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump so light and small,
From point-six up to two-point-one!
The m1cpu hops down the hall,
One tiny change, and now we're done! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title focuses on a dependency version bump, but the PR objectives indicate the primary intent is fixing a macOS arm64 crash in go-m1cpu initialization—a bug fix, not a routine dependency update. Update the title to reflect the actual objective: 'fix: avoid macOS arm64 crash in go-m1cpu initialization' or similar, which better communicates the bug fix intent rather than just the dependency update mechanism.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dwisiswant0 dwisiswant0 changed the title fix: avoid macOS arm64 crash in go-m1cpu initialization chore(deps): bump github.com/shoenig/go-m1cpu to v0.2.1 Apr 5, 2026
Copy link
Copy Markdown
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not crashing for you? I don't have a darwin environment to test this on. Can you let us know what chip you're running?

Copy link
Copy Markdown
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a transitive dependency, I believe the right move is to bump in the github.com/projectdiscovery/utils dependency because that's the one indirectly consuming it via github.com/shirou/gopsutil/v3/process package anyway.

$ go mod why github.com/shoenig/go-m1cpu
# github.com/shoenig/go-m1cpu
github.com/projectdiscovery/nuclei/v3/cmd/nuclei
github.com/projectdiscovery/utils/update
github.com/projectdiscovery/utils/process
github.com/shirou/gopsutil/v3/process
github.com/shirou/gopsutil/v3/cpu
github.com/shoenig/go-m1cpu

@dwisiswant0
Copy link
Copy Markdown
Member

Superseded by projectdiscovery/utils#738.

@dwisiswant0 dwisiswant0 closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Crash on macOS (Apple Silicon): SIGSEGV in go-m1cpu during initialization

2 participants