chore(deps): bump github.com/shoenig/go-m1cpu to v0.2.1#7328
chore(deps): bump github.com/shoenig/go-m1cpu to v0.2.1#7328bcdlbgm wants to merge 1 commit intoprojectdiscovery:devfrom
Conversation
WalkthroughUpdated the indirect dependency Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dwisiswant0
left a comment
There was a problem hiding this comment.
is this not crashing for you? I don't have a darwin environment to test this on. Can you let us know what chip you're running?
There was a problem hiding this comment.
Since it's a transitive dependency, I believe the right move is to bump in the github.com/projectdiscovery/utils dependency because that's the one indirectly consuming it via github.com/shirou/gopsutil/v3/process package anyway.
$ go mod why github.com/shoenig/go-m1cpu
# github.com/shoenig/go-m1cpu
github.com/projectdiscovery/nuclei/v3/cmd/nuclei
github.com/projectdiscovery/utils/update
github.com/projectdiscovery/utils/process
github.com/shirou/gopsutil/v3/process
github.com/shirou/gopsutil/v3/cpu
github.com/shoenig/go-m1cpu|
Superseded by projectdiscovery/utils#738. |
Proposed changes
Proof
Checklist
Summary by CodeRabbit
Chores