Merged
Conversation
- Fix errcheck errors by properly handling return values of Close() calls - Fix staticcheck issues by replacing WriteString(fmt.Sprintf()) with fmt.Fprintf() - Improve error handling in tests
dogancanbakir
approved these changes
May 2, 2025
Member
|
i guess we missed two places https://github.com/projectdiscovery/pdtm/actions/runs/14797513202/job/41548809052?pr=405#step:4:48 |
Contributor
Author
|
should do. :) |
Member
|
Thanks a lot! @x-stp |
Contributor
Author
no worries, feel like this can go onto main soon ;) |
Member
Contributor
Author
Neat. This is a repo I'll definitely commit to in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because CI. @dogancanbakir
Fixes errcheck errors by "properly" handling return values of Close() calls