Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 12, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
software.amazon.awssdk:bom 2.31.35 -> 2.31.44 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (squash) May 12, 2025 03:06
renovate-approve[bot]
renovate-approve bot previously approved these changes May 12, 2025
@snazy snazy force-pushed the renovate/aws-java-sdk-v2-monorepo branch from cc4f7b9 to e5dd45a Compare May 12, 2025 18:14
for (var inetAddresses = networkInterface.getInetAddresses();
inetAddresses.hasMoreElements(); ) {
var inetAddress = inetAddresses.nextElement();
if ("localhost".equals(inetAddress.getHostName())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may trigger a reverse name lookup :-(

InetAddress local = InetAddress.getLoopbackAddress();
InetAddress localhost = null;
try {
for (var networkInterfaces = NetworkInterface.getNetworkInterfaces();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have to do non-trivial code changes to use new lib versions, I believe it makes sense to do them in "manual" PRs, because Renovate RPs are usually hidden in change logs.

LOGGER.debug("Using inetAddress {} for the local http server", local);
}
try {
server.bind(new InetSocketAddress(local, port), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea to explore: maybe bind to the wildcard address by using the InetSocketAddress(int port) constructor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wildcard sounds like a good idea to me :)

}
server.createContext(CONTEXT_PATH, handler);
InetAddress local = InetAddress.getLoopbackAddress();
InetAddress localhost = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does an AWS SDK version bump affect our client auth code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current PRs are affected by something else. I suspect some IPv4 vs 6 thing - but just a wild guess at this point.

@snazy
Copy link
Member

snazy commented May 14, 2025

Note that the changes here were just experiments. The actual change is #10818

@renovate renovate bot force-pushed the renovate/aws-java-sdk-v2-monorepo branch from e5dd45a to d4a65b6 Compare May 14, 2025 07:49
@renovate renovate bot changed the title Update dependency software.amazon.awssdk:bom to v2.31.40 Update dependency software.amazon.awssdk:bom to v2.31.42 May 14, 2025
@renovate renovate bot force-pushed the renovate/aws-java-sdk-v2-monorepo branch from d4a65b6 to b21dcd0 Compare May 14, 2025 23:35
@renovate renovate bot changed the title Update dependency software.amazon.awssdk:bom to v2.31.42 Update dependency software.amazon.awssdk:bom to v2.31.43 May 14, 2025
@renovate renovate bot force-pushed the renovate/aws-java-sdk-v2-monorepo branch from b21dcd0 to 631b8ad Compare May 15, 2025 23:53
@renovate renovate bot changed the title Update dependency software.amazon.awssdk:bom to v2.31.43 Update dependency software.amazon.awssdk:bom to v2.31.44 May 15, 2025
@renovate renovate bot force-pushed the renovate/aws-java-sdk-v2-monorepo branch 2 times, most recently from f29cea0 to 9419214 Compare May 16, 2025 14:15
@renovate renovate bot force-pushed the renovate/aws-java-sdk-v2-monorepo branch from 9419214 to aaa0d3c Compare May 16, 2025 14:17
@renovate renovate bot merged commit 3dfe7ec into main May 16, 2025
16 checks passed
@renovate renovate bot deleted the renovate/aws-java-sdk-v2-monorepo branch May 16, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants