-
Notifications
You must be signed in to change notification settings - Fork 168
Update dependency software.amazon.awssdk:bom to v2.31.44 #10806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc4f7b9 to
e5dd45a
Compare
| for (var inetAddresses = networkInterface.getInetAddresses(); | ||
| inetAddresses.hasMoreElements(); ) { | ||
| var inetAddress = inetAddresses.nextElement(); | ||
| if ("localhost".equals(inetAddress.getHostName())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may trigger a reverse name lookup :-(
| InetAddress local = InetAddress.getLoopbackAddress(); | ||
| InetAddress localhost = null; | ||
| try { | ||
| for (var networkInterfaces = NetworkInterface.getNetworkInterfaces(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have to do non-trivial code changes to use new lib versions, I believe it makes sense to do them in "manual" PRs, because Renovate RPs are usually hidden in change logs.
| LOGGER.debug("Using inetAddress {} for the local http server", local); | ||
| } | ||
| try { | ||
| server.bind(new InetSocketAddress(local, port), 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea to explore: maybe bind to the wildcard address by using the InetSocketAddress(int port) constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wildcard sounds like a good idea to me :)
| } | ||
| server.createContext(CONTEXT_PATH, handler); | ||
| InetAddress local = InetAddress.getLoopbackAddress(); | ||
| InetAddress localhost = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does an AWS SDK version bump affect our client auth code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All current PRs are affected by something else. I suspect some IPv4 vs 6 thing - but just a wild guess at this point.
|
Note that the changes here were just experiments. The actual change is #10818 |
e5dd45a to
d4a65b6
Compare
d4a65b6 to
b21dcd0
Compare
b21dcd0 to
631b8ad
Compare
f29cea0 to
9419214
Compare
9419214 to
aaa0d3c
Compare
This PR contains the following updates:
2.31.35->2.31.44Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.