Skip to content

Custom handling of HTTP errors #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastianrusu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Custom handling of HTTP errors #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ json_t *json_rpc_call(CURL *curl, const char *url,
json_error_t err;
struct curl_slist *headers = NULL;
char len_hdr[64];
char curl_err_str[CURL_ERROR_SIZE];
char curl_err_str[CURL_ERROR_SIZE] = {0};
long timeout = (flags & JSON_RPC_LONGPOLL) ? opt_timeout : 30;
struct header_info hi = {0};

Expand Down Expand Up @@ -422,6 +422,9 @@ json_t *json_rpc_call(CURL *curl, const char *url,

curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headers);

// force the call to return all info despite failure
curl_easy_setopt(curl, CURLOPT_FAILONERROR, false);

rc = curl_easy_perform(curl);
if (curl_err != NULL)
*curl_err = rc;
Expand All @@ -435,6 +438,32 @@ json_t *json_rpc_call(CURL *curl, const char *url,
goto err_out;
}

// in case of error, process the error and exit
curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &http_rc);
if (http_rc < 200 || http_rc >= 300) {
if (!((flags & JSON_RPC_LONGPOLL) && rc == CURLE_OPERATION_TIMEDOUT) &&
!((flags & JSON_RPC_QUIET_404) && http_rc == 404) && strlen(curl_err_str) != 0)
applog(LOG_ERR, "HTTP request failed: %s", curl_err_str);
if ((flags & JSON_RPC_QUIET_404) && http_rc == 404)
*curl_err = CURLE_OK;
if (http_rc == 500) {
json_buf = hack_json_numbers(all_data.buf);
errno = 0; /* needed for Jansson < 2.1 */
val = JSON_LOADS(json_buf, &err);
free(json_buf);
if (val) {
err_val = json_object_get(val, "error");
const char *message = json_string_value(json_object_get(err_val, "message"));
if (strstr(message, "too-few-votes"))
applog(LOG_ERR, "Waiting for new work -- Not enough votes for currently block");
else
applog(LOG_ERR, "HTTP request failed: %s", message);
}
*curl_err = CURLE_HTTP_RETURNED_ERROR;
}
goto err_out;
}

/* If X-Stratum was found, activate Stratum */
if (want_stratum && hi.stratum_url &&
!strncasecmp(hi.stratum_url, "stratum+tcp://", 14)) {
Expand Down