Pierre's library modules submission#29
Open
pierre-lourens wants to merge 3 commits intoprojectshft:masterfrom
Open
Pierre's library modules submission#29pierre-lourens wants to merge 3 commits intoprojectshft:masterfrom
pierre-lourens wants to merge 3 commits intoprojectshft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a bit carried away with some free time tonight.. my main concern is whether the attribute "checkedOut" should be false by default for books created by the Book module, because it feels weird to me for some reason to set a default value like that, but it passed the tests. Also I have no idea what to write in this box for a pull request.