Skip to content

Project submission for post and comments#215

Open
colormethanh wants to merge 18 commits intoprojectshft:masterfrom
colormethanh:master
Open

Project submission for post and comments#215
colormethanh wants to merge 18 commits intoprojectshft:masterfrom
colormethanh:master

Conversation

@colormethanh
Copy link

No description provided.

@colormethanh
Copy link
Author

sumitting project

@colormethanh
Copy link
Author

Resubmitting project

@colormethanh
Copy link
Author

Changed modal font color

@colormethanh
Copy link
Author

Updated ReadMe

@@ -0,0 +1,143 @@

export class SocialMedia {
#posts;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the # ?

return new Comment(author, text, this);
};

addComment(author, text){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function name doesnt match what it is actually doing. Its adding but also getting, maybe worth separating the logic

this.#posts = [];
}

setPost(postArray) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this update posts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments