Open
Conversation
…ore work to be even less DRY.
| </head> | ||
| <body> | ||
| <div class="container-fluid"> | ||
| <h1>Forum</h1> |
There was a problem hiding this comment.
instead of h1 and h2, you can use display-1, display-2 from bootstrap.
| </div> | ||
| </div>`; | ||
|
|
||
| let posts = [ |
There was a problem hiding this comment.
great, good practice to decouple logic
| }); | ||
| }; | ||
|
|
||
| const handleComments = function () { |
There was a problem hiding this comment.
this function is too big and its handling too much, you can extract some responsibilities to other functions like toggling visibility, adding comments, deleting comments. This will be very hard to debug or maintain and scale. Whenever you see such a big function in your code, that should turn a red or yellow flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cohort 14 - Part Time
Mecca Conway