Open
Conversation
| @@ -0,0 +1,54 @@ | |||
| .comments-section { | |||
There was a problem hiding this comment.
many of the classes here you can achieve with bootstrap like m-3 for margins or btn-block
| const postButton = document.getElementById('submit'); | ||
| const messageBoard = document.getElementById('posts'); // Container for posts | ||
|
|
||
| var messages = []; |
There was a problem hiding this comment.
why var and not const or let? avoid var
| var messages = []; | ||
|
|
||
| // Function to display messages dynamically | ||
| function postMessages() { |
| // Function to create a message element | ||
| function createMessageElement(message, index) { | ||
| var div = document.createElement('div'); | ||
| div.className = 'message'; |
There was a problem hiding this comment.
this can be a const on top of the file and then you use it.
| } | ||
|
|
||
| // Function to create a message element | ||
| function createMessageElement(message, index) { |
There was a problem hiding this comment.
this function is huge and very hard to follow, I ended up forgetting Im inside of it while reading it. You have to extract the internal logic to helper functions in order to improve readability and maintainability with your code. Imagine that delete has a bug, will be hard to find here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.