Michael Wagner Weather Eval#13
Open
Michael-Wagner459 wants to merge 4 commits intoprojectshft:mainfrom
Open
Conversation
Comment on lines
+11
to
+12
| <br /> | ||
| <br /> |
There was a problem hiding this comment.
Its not a good practice to use breaks for design purposes. Next time use css
| import rootReducer from './rootReducer'; | ||
|
|
||
| const store = configureStore({ | ||
| reducer: rootReducer, |
| const handleFormSubmit = (event) => { | ||
| event.preventDefault(); | ||
| dispatch(fetchWeather(city)); | ||
| setCity(''); |
There was a problem hiding this comment.
its a better UX to clear the input only after the call is successful. If the user enters a bad input, you want to see it and not clear it
Comment on lines
+27
to
+44
| <td> | ||
| <Sparklines data={city.temp}> | ||
| <SparklinesLine color='blue' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> | ||
| <td> | ||
| <Sparklines data={city.pressure}> | ||
| <SparklinesLine color='red' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> | ||
| <td> | ||
| <Sparklines data={city.humidity}> | ||
| <SparklinesLine color='yellow' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> |
There was a problem hiding this comment.
DRY, don't repeat yourself, use JS helpers and components to make it more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.