Conversation
…ot work on user input.
…ing that city's name isn't displaying properly, it remains the same
… state "Showing data for city, state"
h3 now displaying correctly
…n works good enough. 🤷♀️
| zip: geoZip, | ||
| }; | ||
|
|
||
| return { weatherData: weatherResponse.data, city: `${city}, ${country}` }; |
There was a problem hiding this comment.
irrelevant line of code, this is unaccessible.
| <br></br> | ||
| <h3>Temperature</h3> | ||
| <Sparklines | ||
| data={data.list ? data.list.map((item) => item.main.temp) : []} |
There was a problem hiding this comment.
what is this for?
its creating the empty space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a frustrating one for me. I got it working the way I wanted and then made a mistake merging one branch into another and lost a bunch of work. And this is after spending tons of extra time and days on a feature that wasn't even a requirement. Anywayyyyy sorry for the spaghetti code in advance dear evaluator.