revert c5b3932 (permission for any requested URL)#41
Open
justinsteven wants to merge 1 commit intoprolane:masterfrom
Open
revert c5b3932 (permission for any requested URL)#41justinsteven wants to merge 1 commit intoprolane:masterfrom
justinsteven wants to merge 1 commit intoprolane:masterfrom
Conversation
This is no longer needed. <https://crbug.com/918137> rescoped the Chrome change. You now only need permission for the initiator to intercept **subresource** requests. Intercepting top level navigation is permitted with permission for only the AWS URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer needed. https://crbug.com/918137 rescoped the Chrome
change. You now only need permission for the initiator to intercept
subresource requests. Intercepting top level navigation is permitted with
permission for only the AWS URL.
I tested it just fine on Chromium and Firefox for an AWS account for which I can only assume one profile. This matches the scenario in which #28 was breaking.
Please do more extensive tests, I'm only vaguely familiar with the SAML/STS dance.