Skip to content

Improve code consistency and clarity#8

Open
MarkBiesheuvel wants to merge 8 commits intoprolane:masterfrom
MarkBiesheuvel:master
Open

Improve code consistency and clarity#8
MarkBiesheuvel wants to merge 8 commits intoprolane:masterfrom
MarkBiesheuvel:master

Conversation

@MarkBiesheuvel
Copy link

@MarkBiesheuvel MarkBiesheuvel commented Nov 27, 2017

This pull request does the following things:

  • Replace all Windows line endings \r\n by Unix line endings \n. (See this line if you still want Windows line enings locally)
  • Replace all tabs by spaces, as it was a mixture of both before.
  • Remove trailing whitespace at end of line
  • Define a code style with eslint
  • Replaces css styling on id by styling on class names
  • Replace custom HTML generation by jQuery functions
  • Replace recursive calls of assumeRole by Promises

I understand that this is a big overhaul, so I tried to not change any functionality.
It is probably best to review it commit by commit.

Hopefully you find this suggestion useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant