Skip to content

Prevent logging password as plain text in snapshot and indices collectors #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent logging password as plain text in snapshot and indices collectors #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion collector/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"io"
"log/slog"
"net/http"
"net/url"
)

func getURL(ctx context.Context, hc *http.Client, log *slog.Logger, u string) ([]byte, error) {
Expand All @@ -29,7 +30,13 @@ func getURL(ctx context.Context, hc *http.Client, log *slog.Logger, u string) ([

resp, err := hc.Do(req)
if err != nil {
return nil, fmt.Errorf("failed to get %s: %v", u, err)
// Parse URL to safely format error message without exposing credentials
if parsedURL, parseErr := url.Parse(u); parseErr == nil {
return nil, fmt.Errorf("failed to get %s://%s:%s%s: %v",
parsedURL.Scheme, parsedURL.Hostname(), parsedURL.Port(), parsedURL.Path, err)
}
// Fallback if URL parsing fails - still avoid exposing full URL
return nil, fmt.Errorf("failed to get URL: %v", err)
}

defer func() {
Expand Down