Skip to content

[prometheus-stackdriver-exporter] Disable default namespace for serviceMonitor that can cause incorrect… #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergeyshevch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[prometheus-stackdriver-exporter] Disable default namespace for serviceMonitor that can cause incorrect… #6180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1534f83
Disable default namespace for serviceMonitor that can cause incorrect…
sergeyshevch Oct 2, 2025
3be65b2
Bump chart version
sergeyshevch Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-stackdriver-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Stackdriver exporter for Prometheus
name: prometheus-stackdriver-exporter
version: 4.12.0
version: 4.13.0
appVersion: v0.18.0
home: https://www.stackdriver.com/
sources:
Expand Down
3 changes: 2 additions & 1 deletion charts/prometheus-stackdriver-exporter/templates/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ kind: ServiceMonitor
metadata:
name: {{ template "stackdriver-exporter.fullname" . }}
{{- if .Values.serviceMonitor.namespace }}
namespace: {{ .Values.serviceMonitor.namespace }}
{{- with .Values.serviceMonitor.namespace }}
namespace: {{ . }}
{{- end }}
labels:
{{- include "stackdriver-exporter.labels" . | indent 4 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/prometheus-stackdriver-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ serviceAccount:
# Enable this if you're using https://github.com/coreos/prometheus-operator
serviceMonitor:
enabled: false
namespace: monitoring
namespace: ""
# scrapeClass
scrapeClass:
# additionalLabels is the set of additional labels to add to the ServiceMonitor
Expand Down
Loading