Add more tests for completion / hover#175
Draft
nevill wants to merge 1 commit intoprometheus-community:masterfrom
Draft
Add more tests for completion / hover#175nevill wants to merge 1 commit intoprometheus-community:masterfrom
nevill wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Signed-off-by: Nevill <nevill.dutt@gmail.com>
slrtbtfs
reviewed
Jun 23, 2020
Member
slrtbtfs
left a comment
slrtbtfs
left a comment
There was a problem hiding this comment.
It's great to see some progress on the testing side!
The approach in this PR looks generally sane to me, though it'd be nice to have more test cases.
There is also some non-trivial logic, that chooses what kind of completions should be provided. Those should at some point be tested as well, but that doesn't need to happen in the same PR.
| ) | ||
|
|
||
| // This is a mock object which serves as a test helper | ||
| type MockMetadataService struct { |
Member
There was a problem hiding this comment.
Since this might be used in other tests as well, it should probably live in a separate file.
| t.Errorf("Error occurred when calling completeMetricName: %s.\n", err) | ||
| } | ||
|
|
||
| if len(*items) != 1 { |
Member
There was a problem hiding this comment.
Ideally we would also check the content of the returned items.
slrtbtfs
reviewed
Jun 26, 2020
| return "testhost:9090" | ||
| } | ||
|
|
||
| func TestMetricNameCompletion(t *testing.T) { |
Member
There was a problem hiding this comment.
Suggested change
| func TestMetricNameCompletion(t *testing.T) { | |
| func TestMetricNameCompletion(t *testing.T) { | |
| // nolint: funlen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP. It intends to fix #133 at the end.
To create this draft PR because I want to get some early feedback from @slrtbtfs .