-
Notifications
You must be signed in to change notification settings - Fork 99
fix(nvd): support full CVE rebuild without arg overflow #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b103d6
fix(nvd): add hermes query specs to feed polling
davida-ps dd5e2f8
fix(nvd): derive platform fallback from matched targets
davida-ps 2638481
fix(nvd): avoid arg overflow on full cve rescan
davida-ps 30f99eb
fix(feed): add other platform filter for nonstandard slugs
davida-ps 4e93032
refactor(feed): centralize advisory platform badge mapping
davida-ps 9677b69
fix(feed): share platform normalization and fix tab callback typing
davida-ps 899997c
refactor(feed): simplify platform descriptor fallback
davida-ps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react'; | ||
| import { getPlatformDescriptor } from '../utils/advisoryPlatforms'; | ||
|
|
||
| interface AdvisoryPlatformBadgeProps { | ||
| platform: string; | ||
| className?: string; | ||
| } | ||
|
|
||
| export const AdvisoryPlatformBadge: React.FC<AdvisoryPlatformBadgeProps> = ({ | ||
| platform, | ||
| className, | ||
| }) => { | ||
| const { label, classes } = getPlatformDescriptor(platform); | ||
| const badgeClasses = ['uppercase tracking-wide', classes, className] | ||
| .filter(Boolean) | ||
| .join(' '); | ||
|
|
||
| return <span className={badgeClasses}>{label}</span>; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
community-advisory.ymlstill maps arbitraryOther:slugs intoplatformseven though platform tabs only coveropenclaw,nanoclaw, andhermes, so approved nonstandard slugs won’t show in filtered views—should we constrain the contract to that set or add another/catch-all path?Finding type:
Type Inconsistency| Severity: 🟢 LowWant Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 30f99eb addressed this comment by introducing a typed platform filter that includes an “Other” tab, normalizing incoming platform slugs, and filtering any advisory whose slug isn’t in the CORE_PLATFORM_SLUGS set under that catch-all option so nonstandard slugs remain discoverable.