fix: make VectorStore thread-safe for watcher daemon#11
Merged
Conversation
The file watcher's DebouncedHandler fires callbacks on threading.Timer threads, but VectorStore's SQLite connection was created on the main thread. This caused every indexing attempt to fail with "SQLite objects created in a thread can only be used in that same thread". Add check_same_thread=False and a threading.Lock to VectorStore so all public methods are safe to call from any thread. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DebouncedHandlerfires callbacks onthreading.Timerthreads, butVectorStore's SQLite connection enforced same-thread usage — causing every indexing attempt to fail withProgrammingErrorcheck_same_thread=Falseand athreading.LocktoVectorStore, wrapping all public methods for thread-safe accessTestThreadSafetytests covering cross-thread upsert and concurrent multi-thread upsertsTest plan
TestThreadSafety::test_upsert_from_different_thread,TestThreadSafety::test_concurrent_upserts_from_multiple_threads)🤖 Generated with Claude Code