Update cd_frame_generator.cpp #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the events are accumulated into frames where the accumulation windows are overlapping in nature, the "fps" and "display_accumulation_time_us" ideally should be decoupled from each other. The variable "notify_slice_us_", conditional on the value of "display_accumulation_time_us", seems to affect the output framerate in proportion to the event accumulation time. For example, if the fps is set to 100Hz, and the accumulation time is set to 50000us, next_notify_us_ is set to 50000/3 = 1666.67, making the resultant output framerate 60Hz even when CPU cores are available. The proposed change to set notify_slice_us_ to a constant 100us attempts to decouple output frame rate from event accumulation times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the events are accumulated into frames where the accumulation windows are overlapping in nature, the "fps" and "display_accumulation_time_us" ideally should be decoupled from each other. The variable "notify_slice_us_", conditional on the value of "display_accumulation_time_us", seems to affect the output framerate in proportion to the event accumulation time. For example, if the fps is set to 100Hz, and the accumulation time is set to 50000us, next_notify_us_ is set to 50000/3 = 1666.67, making the resultant output framerate 60Hz even when CPU cores are available. The proposed change to set notify_slice_us_ to a constant 100us attempts to decouple output frame rate from event accumulation times.