feat: Validation & Adaptation (Issue #3)#13
Merged
Conversation
- Add 16 tests covering validation, identify, track, and page events - Add stream field to TypedEvent for event routing - Fix field names to use snake_case (user_id, anonymous_id) - 88% coverage on SegmentSchemaAdapter
- Add Validation & Adaptation section with code examples - Document ValidationPipeline and composable validators - Document SegmentSchemaAdapter usage - Update roadmap to show completed features - Mark Tasks 5 & 6 complete in tasks.md - Rename test_base.py → test_validator_protocol.py (fix pytest collision) - 66 tests passing, 87% overall coverage
- Fix duplicate stream field in TypedEvent - Add dict[str, Any] type annotations to all validators - Add types-python-dateutil stub package - Fix Pydantic alias usage ($set/$set_once via **kwargs) - Fix timestamp None handling with explicit fallback - Add return type annotation to __init__ - Add assertion for validator error message invariant - All tests pass (86), mypy clean, 95% coverage
prosdev
force-pushed
the
feat/validation-and-adaptation
branch
from
6150bc6 to
9d39e13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements composable validators and Segment-compatible schema adapter for type-safe event processing.
Features
Validators (Task 5)
Segment Schema Adapter (Task 6)
AdapterResult.success/failure)Architecture
Two-Tier Design (Future-Proof):
RawEventTypedEventThis enables seamless integration with future
eventkit-schemapackage for dynamic per-account schemas.Testing
SegmentSchemaAdapterCommits
feat(validators): add Validator protocolfeat(validators): add RequiredFieldsValidatorfeat(validators): add TypeCheckValidatorfeat(validators): add TimestampValidator with ISO8601 and Unix supportfeat(validators): add ValidationPipeline for composable validationfeat(adapter): add SegmentSchemaAdapter with ValidationPipelinetest(adapter): add comprehensive SegmentSchemaAdapter testsfeat(adapter): export SegmentSchemaAdapter from packagedocs: update README with validator and adapter detailsCloses #3