Skip to content

fix(ui): apply ASCII logo gradient by X column, not string index#72

Open
mabry1985 wants to merge 1 commit intodevfrom
fix/ascii-gradient-x-axis
Open

fix(ui): apply ASCII logo gradient by X column, not string index#72
mabry1985 wants to merge 1 commit intodevfrom
fix/ascii-gradient-x-axis

Conversation

@mabry1985
Copy link
Copy Markdown

Problem

The p's descender (bottom two lines of the ASCII logo) was rendering pink/purple instead of blue. ink-gradient maps gradient colors by character index across the entire multi-line string — so the last lines always got the tail color regardless of their leftward visual position.

Fix

Render each logo line in its own <Gradient>, padded to logoWidth with trailing spaces. This ensures column X maps to the same gradient fraction on every line — character at x=3 is always ~10% through the gradient (blue) whether it's on line 1 or line 9.

🤖 Generated with Claude Code

ink-gradient maps colors by character index across the whole string, so
the p descender (last two lines) always got the tail/pink color regardless
of its leftward visual position.

Fix: render each logo line separately with its own <Gradient>, padded to
logoWidth so column X maps to the same gradient fraction on every line.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mabry1985 mabry1985 enabled auto-merge (squash) April 15, 2026 01:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@mabry1985 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 58 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 58 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b34f0f70-087e-4b9e-952c-36486e5190aa

📥 Commits

Reviewing files that changed from the base of the PR and between 4146d4b and a9ee18d.

📒 Files selected for processing (1)
  • packages/cli/src/ui/components/Header.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ascii-gradient-x-axis

Comment @coderabbitai help to get the list of available commands and usage tips.

@mabry1985 mabry1985 mentioned this pull request Apr 15, 2026
@mabry1985 mabry1985 requested a review from gnostichumor April 19, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant