Open
Conversation
hgn
reviewed
Apr 9, 2019
dmpr/dmpr.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
| mylog = logging.getLogger("mylog") | ||
| fh = logging.FileHandler('/var/logs/tmp/myLog.txt') |
Member
There was a problem hiding this comment.
the path is completly b0rken:
- please let the user the ability where to log, not silently log somewhere. You should log to stderr if not known
- the directory is probably not available
- /var/logS is not a valid path /var/log (but see other comment)
- please always name the logfile of path to your application, nobody known that myLog is dmpr
- no camel case for linux filenames, that is not linux (see FHS pdf, the linux standard)
Author
There was a problem hiding this comment.
the logger is unnecessary anyways (just for debug purposes) - deleted for the merge
hgn
requested changes
Apr 9, 2019
dmpr/dmpr.py
Outdated
| logmsg = dict() | ||
| logmsg['event'] = 'update-interval' | ||
| logmsg['msg'] = self.id | ||
| mylog.error(logmsg) |
Member
There was a problem hiding this comment.
it's missing the IPv6 part completly.
dmpr/dmpr.py
Outdated
| database and trigger all recalculations | ||
| """ | ||
|
|
||
| print("rx {}".format(msg['id'])) |
| self.msg_db[interface_name][msg['id']] = message | ||
| self.state.update_required = True | ||
| # check if already attributes known | ||
| if message.addr_v4 in interface['neighbor-attributes']['unknown']: |
Member
|
The rest if fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DMPR is now able to handle dynamic link updates. The dynamic updates are received by rest-api.
The information can be provided for example by any Radio-to-Router communication protocols (e.g. DLEP).
The new feature is tested in mininet simulation environment as well as on real hardware