Skip to content

Refactor Github Action per b/485167538 #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-admin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor Github Action per b/485167538 #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/publish-build-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ jobs:
- name: Generate tag
id: tag
run: |
TAG="ubuntu-${{ github.event.inputs.ubuntu_version }}-bazel-${{ github.event.inputs.bazel_version }}"
TAG="ubuntu-${GITHUB_EVENT_INPUTS_UBUNTU_VERSION}-bazel-${GITHUB_EVENT_INPUTS_BAZEL_VERSION}"
echo "tag=$TAG" >> $GITHUB_OUTPUT
env:
GITHUB_EVENT_INPUTS_UBUNTU_VERSION: ${{ github.event.inputs.ubuntu_version }}
GITHUB_EVENT_INPUTS_BAZEL_VERSION: ${{ github.event.inputs.bazel_version }}
Comment on lines +49 to +53
Copy link
Contributor

@mmorel-35 mmorel-35 Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be working too ?

Suggested change
TAG="ubuntu-${GITHUB_EVENT_INPUTS_UBUNTU_VERSION}-bazel-${GITHUB_EVENT_INPUTS_BAZEL_VERSION}"
echo "tag=$TAG" >> $GITHUB_OUTPUT
env:
GITHUB_EVENT_INPUTS_UBUNTU_VERSION: ${{ github.event.inputs.ubuntu_version }}
GITHUB_EVENT_INPUTS_BAZEL_VERSION: ${{ github.event.inputs.bazel_version }}
echo "tag=$TAG" >> $GITHUB_OUTPUT
env:
TAG: "ubuntu-${{ github.event.inputs.ubuntu_version }}-bazel-${{ github.event.inputs.bazel_version }}"

Copy link
Contributor

@mmorel-35 mmorel-35 Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it just even be a job env variable ?


- name: Login to GitHub Container Registry
if: ${{ !github.event.inputs.draft }}
Expand Down
Loading