This repository was archived by the owner on Sep 7, 2020. It is now read-only.
Draft
Conversation
The type of the mac address parameter is incorrect. Changed sta_mac from char[6] to uint8_t[6]. Signed-off-by: Itay Elenzweig <itayx.elenzweig@intel.com>
- In client_set_client changed incoming type from INT_ARG to STRING_ARG. Since we are using optional parameters, we need to retrieve them from the CLI as strings, then convert them to integers. - Added int conversion in the client_set_client LOG print. To print the incoming values in client_set_client, need to convert them to type int, otherwise they will be printed as Char - Added tlvf::mac_to_string in the client_get_client LOG print. The received mac address needs to be converted to a readable format to be printed. Signed-off-by: Itay Elenzweig <itayx.elenzweig@intel.com>
Changed returning error values in the code to a negative value as expected by the BML. PPM-5. Signed-off-by: Itay Elenzweig <itayx.elenzweig@intel.com>
Refactored the response handling for the "get_client" implementation. Fixed broken return on error in the "get_client" implementation. PPM-5. Signed-off-by: Itay Elenzweig <itayx.elenzweig@intel.com>
As part of the persistent DB, some configuration parameters can be set to "NOT_CONFIGURED" meaning they will not be stored persistently. Verify that the given client configuration parameters are configured before sending the change request. Signed-off-by: Itay Elenzweig <itayx.elenzweig@intel.com>
itayx
requested review from
adam1985d,
arnout,
kantera800,
mariomaz,
morantr,
rmelotte,
tomereli and
vitalybu
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BML Smart-Steering feature fixups and cleanups
PPM-5