Skip to content
This repository was archived by the owner on Sep 7, 2020. It is now read-only.

PPM-338 Move UCI configuration to Agent DB#1590

Draft
orenvor wants to merge 24 commits intomasterfrom
feature/PPM-338-move-uci-config-to-agent-db
Draft

PPM-338 Move UCI configuration to Agent DB#1590
orenvor wants to merge 24 commits intomasterfrom
feature/PPM-338-move-uci-config-to-agent-db

Conversation

@orenvor
Copy link
Collaborator

@orenvor orenvor commented Aug 9, 2020

This PR moves agent configuration from the local "sPlatformSettings" struct to the AgentDB.
Preparation for unified agent task.

@orenvor orenvor force-pushed the feature/PPM-338-move-uci-config-to-agent-db branch 3 times, most recently from a6aef83 to 1e63f24 Compare August 11, 2020 09:37
@orenvor orenvor marked this pull request as ready for review August 11, 2020 09:40
@orenvor orenvor marked this pull request as draft August 11, 2020 12:24
@orenvor orenvor force-pushed the feature/PPM-338-move-uci-config-to-agent-db branch 2 times, most recently from 45ee140 to 28a3225 Compare August 12, 2020 15:01
@morantr morantr mentioned this pull request Aug 12, 2020
Open
orenvor added 13 commits August 13, 2020 10:37
@orenvor
agent: Move front radio configuration to AgentDB
1ed9087 
Move front radio configuration from "sPlatformSettings" struct
to the AgentDB.
Replace the use of front radio settings on the Agent thread to the one
on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move back radio configuration to AgentDB
198dd29 
Move back radio configuration from "sPlatformSettings" struct
to the AgentDB.
Replace the use of back radio settings on the Agent thread to the one
on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move mem_only_psk configuration to AgentDB
b940541 
Move "mem_only_psk" configuration of back radio from "sPlatformSettings"
struct to the AgentDB.
Replace the use of "mem_only_psk" settings on the Agent thread to
the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move backhaul_max_vaps configuration to AgentDB
fa19acb 
Move "backhaul_max_vaps" configuration of back radio from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "backhaul_max_vaps" settings on the Agent thread to
the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move backhaul_network_enabled configuration to AgentDB
bd04912 
Move "backhaul_network_enabled" configuration of back radio from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "backhaul_network_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move backhaul_preferred_radio_band configuration to AgentDB
6d15f7e 
Move "backhaul_preferred_radio_band" configuration of back radio from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "backhaul_preferred_radio_band" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move operating_mode configuration to AgentDB
6af1e0b 
Move "operating_mode" configuration of from "sPlatformSettings" struct
to the AgentDB.
Replace the use of "operating_mode" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move management_mode configuration to AgentDB
e59af3a 
Move "management_mode"  configuration of from "sPlatformSettings" struct
to the AgentDB.
Replace the use of "management_mode" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move certification_mode configuration to AgentDB
84178c6 
Move "certification_mode" configuration of from "sPlatformSettings"
struct to the AgentDB.
Replace the use of "certification_mode" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move stop_on_failure_attempts configuration to AgentDB
8d7e394 
Move "stop_on_failure_attempts" configuration from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "stop_on_failure_attempts" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move client_band_steering_enabled configuration to AgentDB
b13191f 
Move "client_band_steering_enabled" configuration from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "client_band_steering_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move client_optimal_path_roaming_enabled configuration to AgentDB
d6d17b4 
Move "client_optimal_path_roaming_enabled" configuration from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "client_optimal_path_roaming_enabled" settings on the
Agent thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move dfs_reentry_enabled configuration to AgentDB
f166c0a 
Move "dfs_reentry_enabled" configuration from "sPlatformSettings" struct
to the AgentDB.
Replace the use of "dfs_reentry_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
orenvor added 11 commits August 13, 2020 10:37
@orenvor
agent: Move client_optimal_path_prefer_signal_strength to AgentDB
ced7c3d 
Move "client_optimal_path_roaming_prefer_signal_strength_enabled"
configuration from "sPlatformSettings" struct to the AgentDB.
Replace the use of
"client_optimal_path_roaming_prefer_signal_strength_enabled"
settings on the Agent thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move client_11k_roaming_enabled configuration to AgentDB
1c890a3 
Move "client_11k_roaming_enabled" configuration from "sPlatformSettings"
struct to the AgentDB.
Replace the use of "client_11k_roaming_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move load_balancing_enabled configuration to AgentDB
d672a81 
Move "load_balancing_enabled" configuration from "sPlatformSettings"
struct to the AgentDB.
Replace the use of "load_balancing_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move service_fairness_enabled configuration to AgentDB
9565fce 
Move "service_fairness_enabled" configuration from "sPlatformSettings"
struct to the AgentDB.
Replace the use of "service_fairness_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move rdkb_extensions_enabled configuration to AgentDB
b9541a9 
Move "rdkb_extensions_enabled" configuration of back radio from
"sPlatformSettings" struct to the AgentDB.
Replace the use of "rdkb_extensions_enabled" settings on the Agent
thread to the one on the AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: remove unused onboarding configuration
5477bb5 
Remove unused "onboarding" configuration from "sPlatformSettings"
struct.

Replace the use of "onboarding" with false value.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
tlvf: beerocks_message::sPlatformSettings remove unused settings
e3efdfb 
Remove of unused fields from sPlatformSettings struct.
Those fields have been moved to the Agent_DB and there for no longer
needed as part of a beerocks massage.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Remove "platform_settings" local variable from son_slave_thread
c666a11 
Remove "platform_settings" local variable from son_slave_thread.
Replace the use of "platform_settings" to the settings in AgentDB.

Removing of the config from the tlvf will take place on future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
agent: Move wlan_settings configuration to AgentDB
2831a7d 
Move "wlan_settings" configuration from son_slave_thread local variable
to the AgentDB.

Currently son_slave receive "wlan_settings" from platform_manager
using "PLATFORM_SON_SLAVE_REGISTER_REQUEST/RESPONSE" messages,
and save the settings in a local variable.

This transfer will be replaced by the use of agent_db to pass and
store "wlan_settings".

Removing of "sWlanSettings" from the tlvf will take place on
future commit.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
fixup! agent: Move wlan_settings configuration to AgentDB
cb51ce9 
Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor
tlvf: PLATFORM_SON_SLAVE_REGISTER_RESPONSE remove unused fields
9c450e9 
Remove of unused fields: sPlatformSettings and wlan_settings
from PLATFORM_SON_SLAVE_REGISTER_RESPONSE message.
Those fields have been moved to the Agent_DB and there for no longer
needed as part of this beerocks massage.

PPM-338

Signed-off-by: Oren Vormaser <oren.vormaser@devalore.com>
@orenvor orenvor force-pushed the feature/PPM-338-move-uci-config-to-agent-db branch from 28a3225 to 9c450e9 Compare August 13, 2020 10:37
mariomaz
mariomaz approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@mariomaz mariomaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it's crazy to have so many commits for this task. It's been a nightmare to review and I just can barely imagine what it was to produce it.

I have a few comments but I'm approving anyway because they are easy to fix in case you decide to do so.

agent/src/beerocks/slave/agent_db.h

char ssid[beerocks::message::WIFI_SSID_MAX_LENGTH];
char pass[beerocks::message::WIFI_PASS_MAX_LENGTH];
char security_type[beerocks::message::WIFI_SECURITY_TYPE_MAX_LENGTH];
Copy link
Collaborator

@mariomaz mariomaz Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doxygen documentation

agent/src/beerocks/slave/agent_db.h

char ssid[beerocks::message::WIFI_SSID_MAX_LENGTH];
char pass[beerocks::message::WIFI_PASS_MAX_LENGTH];
char security_type[beerocks::message::WIFI_SECURITY_TYPE_MAX_LENGTH];
Copy link
Collaborator

@mariomaz mariomaz Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doxygen documentation

agent/src/beerocks/slave/son_slave_thread.h
std::string backhaul_manager_uds;
std::string platform_manager_uds;
sSlaveConfig config;
beerocks_message::sWlanSettings wlan_settings; // from platform manager //
Copy link
Collaborator

@mariomaz mariomaz Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper doxygen documentation

agent/src/beerocks/slave/platform_manager/platform_manager_thread.cpp
msg->platform_settings().stop_on_failure_attempts =
uint8_t(platform_common_conf.stop_on_failure_attempts);
msg->platform_settings().backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps);
db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps);
Copy link
Collaborator

@mariomaz mariomaz Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
db->device_conf.back_radio.backhaul_max_vaps = uint8_t(platform_common_conf.backhaul_max_vaps);
db->device_conf.back_radio.backhaul_max_vaps = static_cast<uint8_t>(platform_common_conf.backhaul_max_vaps);

This PR seems like a good opportunity to replace all these C style casts with the preferred C++ style casts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adam1985d adam1985d Awaiting requested review from adam1985d adam1985d is a code owner

@arnout arnout Awaiting requested review from arnout arnout is a code owner

@kantera800 kantera800 Awaiting requested review from kantera800 kantera800 is a code owner

@morantr morantr Awaiting requested review from morantr morantr is a code owner

@rmelotte rmelotte Awaiting requested review from rmelotte rmelotte is a code owner

@tomereli tomereli Awaiting requested review from tomereli tomereli is a code owner

@vitalybu vitalybu Awaiting requested review from vitalybu vitalybu is a code owner

1 more reviewer

@mariomaz mariomaz mariomaz approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@orenvor orenvor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orenvor @mariomaz