This repository was archived by the owner on Sep 7, 2020. It is now read-only.
PPM-383: Remove the unsupported 60Ghz band option from the selected bands#1599
Open
DanielEdriPurpl wants to merge 2 commits intomasterfrom
Open
PPM-383: Remove the unsupported 60Ghz band option from the selected bands#1599DanielEdriPurpl wants to merge 2 commits intomasterfrom
DanielEdriPurpl wants to merge 2 commits intomasterfrom
Conversation
DanielEdriPurpl
requested review from
adam1985d,
arnout,
kantera800,
mariomaz,
morantr,
rmelotte,
tomereli and
vitalybu
as code owners
orenvor
approved these changes
Aug 13, 2020
DanielEdriPurpl
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
bdaa45c to
a276d5d
Compare
adam1985d
changed the title
adam1985d
changed the title
DanielEdriPurpl
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
a276d5d to
000f024
Compare
adam1985d
approved these changes
Aug 13, 2020
Collaborator
adam1985d
left a comment
adam1985d
left a comment
There was a problem hiding this comment.
good PR - congratulations for your first PR to PRPL.
arnout
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
000f024 to
3b7f9df
Compare
DanielEdriPurpl
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
3b7f9df to
7dff6aa
Compare
arnout
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
7dff6aa to
fb94784
Compare
Collaborator
|
There is something wrong with the autogenerated files: They need to be generated again before this can be merged: https://gitlab.com/prpl-foundation/prplmesh/prplMesh/-/jobs/685221686 |
DanielEdriPurpl
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
fb94784 to
000ceb2
Compare
The 60Ghz band is currently not supported, and shouldn't be part of the available configuration of the selected bands. Remove the 60Ghz from the eSelectedBands enum which is used by the persistent DB. PPM-383 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Remove the 60Ghz option from the BML_CLIENT_SELECTED_BANDS in both bml_defs and bml_cli respectively. PPM-383 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
arnout
force-pushed
the
feature/ppm-383-remove-unsupported-60ghz-band
branch
from
000ceb2 to
4a8396c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove from the persistent DB all references to the unsupported 60GHz band.
This includes the BML CLI, the DB, and anything in between.