This repository was archived by the owner on Sep 7, 2020. It is now read-only.
PPM-385: [Persistent DB]: "Client: Clear client" to the Smart-Steering APIs#1605
Draft
DanielEdriPurpl wants to merge 8 commits intomasterfrom
Draft
PPM-385: [Persistent DB]: "Client: Clear client" to the Smart-Steering APIs#1605DanielEdriPurpl wants to merge 8 commits intomasterfrom
DanielEdriPurpl wants to merge 8 commits intomasterfrom
Conversation
Preparation commit Currently there's only accesor or mutator fns, to communicate with a client's persistent DB. I am adding the missing delete function so the cli could execute a routine to delete a record off the persistent DB using a mac address as an indentifier. Here i add the require .YAML changes PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i add the auto generated code related to the persistentDB delete method PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i add the required changes to BML/CLI to be used with the del function from persistentDB PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i use the code of CLI/BML i declared in the previous commit PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i add the required implementation to the bml internal for the introduction of a new method for persistentDB removal PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i used the impl i've added in the previous commit, to support the new delete persistentDB records via cli PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i add the missing implementation for the removal function off persistentDB PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
Here i use the impl introducted in the previous commit, and adds the support for the son_management to be used with the new delete fn of persistentDB PPM-385 Signed-off-by: DanielEdriPurpl <daniel.edri@devalore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "Client: clear client" API to the Smart-Steering APIs
Add support in BML (BML CLI, BML, BML Internal)
Add support in DB (Both persistent & run-time)
Validate that cleared clients are removed from the persistent DB (But still exist in the run-time DB)
Removal of non-existing clients should return an appropriate response message