Conversation
Modified TEMPERATURE_REGEX, to have the pinda temp as an optional field when matching.
There was a problem hiding this comment.
Pull Request Overview
This PR revises the TEMPERATURE_REGEX to allow the pinda temperature field (and an additional temperature field) to be optional, addressing an issue where temperature telemetry values were not visible when using an older pinda probe configuration.
- Modified the regex pattern to include optional groups for the pinda temperature fields.
- Adjusted whitespace matching to be more flexible.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified TEMPERATURE_REGEX, to have the pinda temp as an optional field when matching.
In my case in my pins.h file i have disabled PINDA_THERMISTOR, as my probe does not have any thermistor (old pinda). Due to this in PrusaLink webgui and also in PrusaConnect temperature values under telemetry were not visible, as the regex was not matching due to the pinda field was mandatory.
Fixes my issue: #1024