-
Notifications
You must be signed in to change notification settings - Fork 4
psadmin Output Processing #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iversond
wants to merge
168
commits into
master
Choose a base branch
from
tuxmon2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a number of changes to how output from
psadminis processed.psadminmixes messages between stdout and stderr (often with normal information in stderr). This PR now offers 3 levels of output you can choose:PS_PSA_OUTPUTpsa. On errors,psawill display stderr frompsadmin.There are some new environment variables to control the output behavior:
PS_PSA_TIMESTAMPtrue- each line will have a timestamp prepended to it - useful withpsa status tux APPDOMto output the Tuxedo Queue stats to filefalse- defaultPS_PSA_NO_BANNERtrue- do not display the command banner - useful with thePS_PSA_OUTPUT=quietoptionfalse- defaultPS_PSA_DEBUGINFO- default - only display informational messagesDEBUG- display debug output including commandsThe other big change is moving command execution into a new
Runnerclass. This simplifies processingpsadminoutput by only having a single execution point. The runner usesOpen3.popen3to execute OS commands, and within the wait_thread we can decide how we process stdout and stderr. Forsummaryandquietoutput, we handle the output after the command has completed rather than stream stdout and stderr.Fixes these issues: #107, #102, #71
Some changes for #88 but still didn't resolve issue