Allow defining a cache as "shared" #167
Open
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the spec (https://tools.ietf.org/html/rfc7234#section-5.2.2.6) it talks about the `private` directive and that a shared cache MUST NOT store the response. This starts by defining the cache as being "shared" and testing for the "shared" attribute on the cache. Fixes: #141
ionrock
force-pushed
the
ionrock/define-shared-caches
branch
from
2df4ce1 to
a53442d
Compare
|
FTR, I have something along these lines in #225 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spec (https://tools.ietf.org/html/rfc7234#section-5.2.2.6) it talks
about the
privatedirective and that a shared cache MUST NOT storethe response.
This starts by defining the cache as being "shared" and testing for
the "shared" attribute on the cache.
Fixes: #141