Break C++ style by pshriwise · Pull Request #33 · pshriwise/openmc

pshriwise · 2026-02-20T05:18:37Z

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Fixes # (issue)

Checklist

I have performed a self-review of my own code
I have run clang-format (version 15) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

pshriwise · 2026-02-20T05:49:58Z

/format plz

github-actions · 2026-02-20T06:07:27Z

No C++ formatting changes were needed for this branch.

Reviewed commit: a650fb5d8bdce8057b568b7e7cc46f8e0273c22d

pshriwise · 2026-02-20T14:06:07Z

/format

pshriwise · 2026-02-20T14:07:44Z

/cpp-format-suggest

github-actions · 2026-02-20T14:08:23Z

No C++ formatting changes were needed for this branch.

Reviewed commit: a650fb5d8bdce8057b568b7e7cc46f8e0273c22d

pshriwise · 2026-02-20T15:07:59Z

/cpp-format-suggest pls

github-actions · 2026-02-20T15:08:09Z

Queued C++ format suggestions run.

github-actions · 2026-02-20T15:29:42Z

Queued C++ format suggestions run.

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

src/plot.cpp

coveralls · 2026-02-20T18:43:28Z

coverage: 81.824% (-0.01%) from 81.838%
when pulling cff99b9 on break-style
into 3f6ed0f on develop.

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

src/plot.cpp

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

src/plot.cpp

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

src/plot.cpp

github-actions · 2026-02-20T19:18:20Z

C++ formatting checks failed. Add the cpp-format-suggest label to this PR to enable inline formatting suggestions on the next run.

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-02-20T19:21:22Z

src/plot.cpp

  }

-  plt->diffuse_fraction() = diffuse_fraction;
+  plt->diffuse_fraction() =  diffuse_fraction;


clang-format suggestion

Suggested change

plt->diffuse_fraction() = diffuse_fraction;

plt->diffuse_fraction() = diffuse_fraction;

github-actions · 2026-02-20T19:22:27Z

C++ formatting checks failed. Add the cpp-format-suggest label to this PR to enable inline formatting suggestions on the next run.

github-actions

Cpp-linter Review

Used clang-format v15.0.7

Click here for the full clang-format patch

diff --git a/src/plot.cpp b/src/plot.cpp
index 9d450d2..ea05552 100644
--- a/src/plot.cpp
+++ b/src/plot.cpp
@@ -2542 +2542 @@ extern "C" int openmc_solidraytrace_plot_set_diffuse_fraction(
-  plt->diffuse_fraction() =  diffuse_fraction;
+  plt->diffuse_fraction() = diffuse_fraction;

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-02-20T19:23:23Z

src/plot.cpp

  }

-  plt->diffuse_fraction() = diffuse_fraction;
+  plt->diffuse_fraction() =  diffuse_fraction;


clang-format suggestion

Suggested change

plt->diffuse_fraction() = diffuse_fraction;

plt->diffuse_fraction() = diffuse_fraction;

github-actions bot added the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

github-actions bot removed the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

github-actions bot added the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

pshriwise force-pushed the break-style branch from a650fb5 to 0a59ac8 Compare February 20, 2026 15:35

github-actions bot reviewed Feb 20, 2026

View reviewed changes

src/plot.cpp Show resolved Hide resolved

pshriwise force-pushed the develop branch from a0f03ec to 53ce191 Compare February 20, 2026 16:05

Break C++ style

249f940

pshriwise force-pushed the break-style branch from 0a59ac8 to 249f940 Compare February 20, 2026 18:53

github-actions bot reviewed Feb 20, 2026

View reviewed changes

src/plot.cpp Show resolved Hide resolved

github-actions bot reviewed Feb 20, 2026

View reviewed changes

src/plot.cpp Show resolved Hide resolved

Empty commit for format suggestions

f4e3b62

github-actions bot reviewed Feb 20, 2026

View reviewed changes

src/plot.cpp Show resolved Hide resolved

pshriwise removed the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

pshriwise added 2 commits February 20, 2026 13:08

Trigger C++ check

e2be78d

Another trigger

cff99b9

pshriwise added the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

github-actions bot reviewed Feb 20, 2026

View reviewed changes

pshriwise removed the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

pshriwise added the cpp-format-suggest Trigger C++ format suggestion workflow label Feb 20, 2026

github-actions bot reviewed Feb 20, 2026

View reviewed changes

pshriwise mentioned this pull request Feb 20, 2026

C++ formatting suggestions on PRs openmc-dev/openmc#3829

Merged

5 tasks

	plt->diffuse_fraction() = diffuse_fraction;
	plt->diffuse_fraction() = diffuse_fraction;

Conversation

pshriwise commented Feb 20, 2026

Description

Checklist

Uh oh!

pshriwise commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

pshriwise commented Feb 20, 2026

Uh oh!

pshriwise commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

pshriwise commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

Uh oh!

coveralls commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

github-actions bot Feb 20, 2026

Choose a reason for hiding this comment

clang-format suggestion

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v15.0.7

Uh oh!

github-actions bot Feb 20, 2026

Choose a reason for hiding this comment

clang-format suggestion

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coveralls commented Feb 20, 2026 •

edited

Loading