Fix shade_color passing nil to hex_to_rgb#5
Open
sekhat wants to merge 1 commit intopsliwka:masterfrom
Open
Conversation
Owner
|
Hi! Could you please add some description on what problem(s) does this change solve? |
Contributor
Author
|
I forget the specifics right now. I'll dig back into later. Off the top of my head though, there was something that was causing nil to be passed as color to shade_color, which got passed to hex_to_rgb, which caused that to error because of it's method call of gsub. |
Contributor
Author
|
Updated PR description. |
Contributor
Author
|
Might be, unintentionally, related to #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error thrown when there is no background color set for the
Normalhighlight.