TASK: remove plow-js and refactor build stack#75
TASK: remove plow-js and refactor build stack#75markusguenther wants to merge 11 commits intopsmb:masterfrom
Conversation
d7c2748 to
b01b63e
Compare
As we are able to resize the left sidebar nowadays we need to adjust the size and ellipsis handling.
|
@markusguenther Thanks for this work! Does this change anything related to Neos dependencies? |
|
Thanks @lorenzulrich as we have transpiled assets, we can use the package also with older Neos Instances. I tried it with Neos 7.3 and Neos 8.0 and it works. But when you want to name it 1.0 I am also fine with that :) flatnav-neos73.1.mp4 |
|
Maybe found a bug with scrolling in div containers. 🙈 |
@markusguenther What's the status on this? Is there a bug or not? If not, I will merge this. |
|
@markusguenther Reminder ;-) |
|
Thanks Markus for the work! As i cant push here is my review pr markusguenther#1
|
Since we changed the build stack in the Neos-UI to esbuild we are able to use the optional chaining (?.) operator in JavaScript. As the modern JavaScript is pretty powerful, we don’t need the helper methods from the plow-js library anymore.
The newer Neos versions also have the new feature to resize the left bar with the content and document tree. So the flatnav containers should also be resizable. This PR removes plow-js and therefore we get rid of the error messages in the console. We also use now esbuild with CSS modules to build the module assets.
With this change, we also lower the external dependencies.