Skip to content

TASK: remove plow-js and refactor build stack#75

Open
markusguenther wants to merge 11 commits intopsmb:masterfrom
markusguenther:task/remove-plow-js
Open

TASK: remove plow-js and refactor build stack#75
markusguenther wants to merge 11 commits intopsmb:masterfrom
markusguenther:task/remove-plow-js

Conversation

@markusguenther
Copy link

@markusguenther markusguenther commented Oct 4, 2024

Since we changed the build stack in the Neos-UI to esbuild we are able to use the optional chaining (?.) operator in JavaScript. As the modern JavaScript is pretty powerful, we don’t need the helper methods from the plow-js library anymore.

The newer Neos versions also have the new feature to resize the left bar with the content and document tree. So the flatnav containers should also be resizable. This PR removes plow-js and therefore we get rid of the error messages in the console. We also use now esbuild with CSS modules to build the module assets.

With this change, we also lower the external dependencies.

@lorenzulrich
Copy link
Collaborator

@markusguenther Thanks for this work! Does this change anything related to Neos dependencies?
https://github.com/psmb/Psmb.FlatNav/blob/master/composer.json#L6C1-L8C1
If so, I suggest we adjust the constraints and release a new major (1.0.0).

@markusguenther
Copy link
Author

Thanks @lorenzulrich as we have transpiled assets, we can use the package also with older Neos Instances. I tried it with Neos 7.3 and Neos 8.0 and it works.

But when you want to name it 1.0 I am also fine with that :)

flatnav-neos73.1.mp4

@markusguenther
Copy link
Author

Maybe found a bug with scrolling in div containers. 🙈

@lorenzulrich
Copy link
Collaborator

Maybe found a bug with scrolling in div containers. 🙈

@markusguenther What's the status on this? Is there a bug or not? If not, I will merge this.

@lorenzulrich
Copy link
Collaborator

@markusguenther Reminder ;-)

@mhsdesign
Copy link

mhsdesign commented Jan 4, 2026

Thanks Markus for the work!

As i cant push here is my review pr markusguenther#1

  • pageTreeContainerOriginal is unused
  • experimentalDecorators must be set to use our @neos and @connect syntax the legacy way
  • esbuild-css-modules-plugin was removed in favour of native css modules by esbuild
  • yarn3 is used instead of ancient 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants