Change sceGuViewport params from int to float #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables more flexibility in configuring viewport as you'd be able to specify it with subpixel precision.
sceGuViewport can still be used as before, with integer parameters and behavior of existing code will remain the same, however if someone for some reason is already using sceGuViewport with float parameters, by relying on conversion from float to int to truncate fractional part, with this change behavior of such implementations will be slightly different as viewport transform may be off by up to 1 pixel. To me it seems unlikely that someone was using it in this way, or that it will have a major impact and break something, but that's not up to me to decide.