Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 86.02% 86.13% +0.10%
==========================================
Files 92 92
Lines 10291 10264 -27
Branches 537 537
==========================================
- Hits 8853 8841 -12
+ Misses 1413 1398 -15
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Rename delete_element_by_id! to delete_element! (NAME-03) - Replace DatabaseException with ArgumentError for type dispatch errors in element.jl - Standardize LuaRunner constructor to use check() pattern - Remove "Lua error:" prefix from run! error messages (ERRH-03) - Update 5 test call sites and 1 test assertion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ndling - Replace 5 DatabaseException with ArgumentError for defensive type branches - Replace manual vector group lookup with get_vector_metadata call - Replace manual set group lookup with get_set_metadata call - Eliminates 7 custom error sites from database_read.jl (ERRH-03) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raphasampaio
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Align Lua binding string with C++ method name (NAME-05) - Update 5 references in test_lua_runner.cpp - Update 1 reference in test_c_api_lua_runner.cpp - Verified ERRH-05: sol2 safe_script preserves C++ exception messages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename deleteElementById to deleteElement (NAME-04) - Factory constructors use check() instead of manual error handling - State guards (_ensureNotClosed, _ensureNotDisposed) throw StateError - Type dispatch errors throw ArgumentError instead of DatabaseException - LuaRunner constructor uses check(), run() removes 'Lua error: ' prefix - Update test assertions to match new exception types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d.dart - readVectorGroupById defensive branch uses ArgumentError - readSetGroupById defensive branch uses ArgumentError - Consistent with codebase type dispatch convention Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.