Open
Conversation
❌ Deploy Preview for precious-lolly-0aa3a0 failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup a test foundation
Installed playwright and playwright-bdd to get a test foundation in place. If you're unfamiliar with BDD it focuses on defining a system's behavior through concrete examples. It's like writing user stories in a language that both developers and non-technical stakeholders can understand.
As features are added to the app, they can be captured and automated so behavior is maintained. Check out the
.featurefiles in this PR to see some simple examples of current behavior that's captured. I even discovered the workouts page was missing a title through this process and was able to add one.The point of this setup is to get a test foundation in place so current behavior can be captured before working on issue #2. This solution would involve some refactoring and the workouts ordering feature is somewhat hard to test as a user because it's time based.
Some helpful commands.
npm testnpm test -- --uinpm test -- --debugFeedback welcome
As always, feel free to pushback, ignore, question or otherwise teach me something. Hopefully this is interesting/useful and will support collaboration on the website.
-- Wanderer