This repository was archived by the owner on Feb 2, 2026. It is now read-only.
Draft
Conversation
aqw
reviewed
Mar 19, 2025
| if template and clone: | ||
| raise ValueError("'template' and 'clone' options are mutually exclusive.") | ||
|
|
||
| auto_message = auto_message or inventory.repo.auto_message |
Collaborator
There was a problem hiding this comment.
Huh. This is new to me.
Just to confirm, this is a shorthand for:
auto_message = inventory.repo.auto_message if auto_message is None else auto_message(or more literally)
auto_message = auto_message if auto_message is not None else iventory.repo.auto_message
Collaborator
Author
There was a problem hiding this comment.
Not exactly.
It's short for auto_message if not auto_message else inventory.repo.auto_message. Which isn't actually what we want, so this was wrong ;-)
aqw
reviewed
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can't possibly pass any tests yet. Just drafting the thing for now.
Sits on top of #780.