Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

update: command helptext#790

Open
TobiasKadelka wants to merge 1 commit intopsyinfra:mainfrom
TobiasKadelka:helptext
Open

update: command helptext#790
TobiasKadelka wants to merge 1 commit intopsyinfra:mainfrom
TobiasKadelka:helptext

Conversation

@TobiasKadelka
Copy link
Copy Markdown
Collaborator

@TobiasKadelka TobiasKadelka commented Apr 1, 2025

Works on #789

I did adjust some existing text because I felt like these sentences can be phrased in a way that is easier and more intuitive to parse for the broad audience. If there is disagreement about these changes, I welcome discussions and can obviously revert parts of it :)

Copy link
Copy Markdown
Collaborator

@aqw aqw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! I left some comments. :-)

Comment thread onyo/cli/mkdir.py Outdated
Comment thread onyo/cli/mkdir.py Outdated
Comment thread onyo/cli/mv.py Outdated
Comment thread onyo/cli/rm.py Outdated
Comment thread onyo/cli/rm.py Outdated
Comment thread onyo/cli/tree.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
@TobiasKadelka TobiasKadelka changed the title WIP: update: command helptext update: command helptext Apr 7, 2025
@TobiasKadelka TobiasKadelka force-pushed the helptext branch 2 times, most recently from eff353a to a0d6d93 Compare April 7, 2025 10:12
@TobiasKadelka
Copy link
Copy Markdown
Collaborator Author

@aqw Thanks for your feedback!

I went through it and adjusted the help texts :)

Copy link
Copy Markdown
Collaborator

@aqw aqw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better.

I left a few nits. Overall getting close.

I'm also interested in @bpoldrack's thoughts about tree.

Comment thread onyo/cli/rm.py Outdated
Comment thread onyo/cli/rm.py Outdated
Comment thread onyo/cli/tree.py
Comment thread onyo/cli/tsv_to_yaml.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
Comment thread onyo/cli/tsv_to_yaml.py Outdated
@TobiasKadelka
Copy link
Copy Markdown
Collaborator Author

Everything was updated and pushed :)

@aqw
Copy link
Copy Markdown
Collaborator

aqw commented Apr 24, 2025

Please fix the ruff lint failures and then this PR is ready to merge. :-D

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@648cd9b). Learn more about missing BASE report.
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage        ?   94.45%           
=======================================
  Files           ?       81           
  Lines           ?     8403           
  Branches        ?      822           
=======================================
  Hits            ?     7937           
  Misses          ?      349           
  Partials        ?      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TobiasKadelka
Copy link
Copy Markdown
Collaborator Author

Please fix the ruff lint failures and then this PR is ready to merge. :-D

I did fix the ruff link failures and now I think this PR is ready to merge :-D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants