This repository was archived by the owner on Feb 2, 2026. It is now read-only.
BF: ensure first --message is not part of the subject#794
Merged
TobiasKadelka merged 1 commit intomainfrom Apr 28, 2025
Merged
Conversation
Git strips trailing newlines, so there's need to detect if there's a follow-up message or not.
Collaborator
|
A small change, looks all good to me! Thanks for working on this so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running (for example)
onyo new --message hahawould not put a blank line between the auto-generated subject and the user-provided message. Thus the first message was part of the subject, which is not desired.Git strips trailing newlines, so there's need to detect if there's a follow-up message or not.