nexus-api: make KeyRepublisher optional, disable it in most tests#754
Draft
ok300 wants to merge 2 commits intopubky:mainfrom
Draft
nexus-api: make KeyRepublisher optional, disable it in most tests#754ok300 wants to merge 2 commits intopubky:mainfrom
nexus-api: make KeyRepublisher optional, disable it in most tests#754ok300 wants to merge 2 commits intopubky:mainfrom
Conversation
Contributor
Author
|
On CI, this reduces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of initializing and starting a
NexusApiinstance isKeyRepublisher::start, which includes a ~2 second blocking call to publish the Nexus PKDNS record.Combined with the fact that tests are run with
nextest, this means a process is started for every test, which spends the first ~2 seconds on publishing a record to the local DHT nodes.Only 2-3 of the ~300
nexus-apitests need the Nexus PKDNS record.This PR makes the
KeyRepublisheroptional and by default disabled in most tests.