Try running tests in GitHub Actions

[jywarren]

Fixes #676

[gitpod-io]

[jywarren]

PL undefined error from main branch! https://travis-ci.com/github/publiclab/PublicLab.Editor/jobs/399630193

[jywarren]

It's been the case since #541, where we added --force to grunt jasmine - it didn't fail there but at some point later it did and then we stopped being able to see when jasmine failed...

[jywarren]

Here is where it began to fail!!!! #597

[jywarren]

I'll try pulling in each commit of woofmark from this list to see when it starts to break:

https://github.com/jywarren/woofmark/commits/plots2

whoaaaaa. i think we need to go back to jywarren/woofmark@12e2c1d...39237b7 ... yikes...

[jywarren]

Reverting back to 12e2c1d or 3695d655c7d11fd3cee8e19f534ccc6722f1297f didn't work... :-(((

[jywarren]

Now trying to look through every line of this commit which is when tests started to show this error: jywarren/woofmark@5cc44d6

[jywarren]

Couldn't find anything! But, i did see that bureaucracy also changed pinned version: https://github.com/publiclab/PublicLab.Editor/pull/597/files

[jywarren]

Seems unlikely to be the problem - the change was really minimal: bevacqua/bureaucracy@master...jywarren:xhrOptions

[jywarren]

So whatever happened in #597, reverting it doesn't get past the PL not defined error.

My theory also that something is breaking in our dist file doesn't make sense either... it's working in Jest. Maybe it's ES6 related? But, then why would... gah... that's back to the status we had in #614.

[jywarren]

Even that's not quite right - we should be Chrome Headless and not Phantomjs now, right? gruntjs/grunt-contrib-jasmine#252 (comment)

[jywarren]

Ah, that only happens in grunt-contrib-jasmine v2+ -- we need to upgrade

[jywarren]

And noting we gave up on that upgrade in #168

[jywarren]

Haha! log: Access to XMLHttpRequest at 'file:///home/runner/work/PublicLab.Editor/PublicLab.Editor/spec/javascripts/fixtures/index.html?_=1611708375140' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, https.

I'll rework that to use a server.

[jywarren]

Ooohhh!!!!

Error: Jasmine Ajax was unable to install over a custom XMLHttpRequest. Is Jasmine Ajax already installed? (1)
>> Error: Jasmine Ajax was unable to install over a custom XMLHttpRequest. Is Jasmine Ajax already installed? Error: Jasmine Ajax was unable to install over a custom XMLHttpRequest. Is Jasmine Ajax already installed?
>>     at MockAjax.install (file:///workspace/PublicLab.Editor/node_modules/jasmine-ajax/lib/mock-ajax.js:575:15)
>>     at UserContext.<anonymous> (file:///workspace/PublicLab.Editor/spec/javascripts/main_image_module_spec.js:50:18)
>>     at <Jasmine>

   X sends AJAX request on editor.publish()
     TypeError: Cannot read property 'blurredLocation' of undefined (1)
>> TypeError: Cannot read property 'blurredLocation' of undefined TypeError: Cannot read property 'blurredLocation' of undefined
>>     at Class.publish (file:///workspace/PublicLab.Editor/dist/PublicLab.Editor.js:21683:34)
>>     at UserContext.<anonymous> (file:///workspace/PublicLab.Editor/spec/javascripts/editor_spec.js:60:12)
>>     at <Jasmine>
   X exists, and has a textarea
     Expected undefined not to be undefined. (1)
>> Expected undefined not to be undefined. Error: Expected undefined not to be undefined.
>>     at <Jasmine>
>>     at UserContext.<anonymous> (file:///workspace/PublicLab.Editor/spec/javascripts/editor_spec.js:14:39)
>>     at <Jasmine>
     Expected <textarea class="ple-textarea form-control wk-hide">...</textarea> to be undefined. (2)
>> Expected <textarea class="ple-textarea form-control wk-hide">...</textarea> to be undefined. Error: Expected <textarea class="ple-textarea form-control wk-hide">...</textarea> to be undefined.
>>     at <Jasmine>
>>     at UserContext.<anonymous> (file:///workspace/PublicLab.Editor/spec/javascripts/editor_spec.js:17:37)
>>     at <Jasmine>

are these all ajax errors???

[jywarren]

I tried setting 'allow-sync-xhr-in-page-dismissal'] in gruntfile because we're getting synchronous AJAX errors, but it didn't seem to work:

log: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

[jywarren]

Noting synch ajax was disallowed in chrome 80, should check the chrome driver version and how to flag that one

[jywarren]

Could use StubRequest to switch jquery-ajax to synchronous: https://jasmine.github.io/2.0/ajax.html#section-12

jasmine/jasmine-ajax#26

[jywarren]

Wow this is working! I think we should merge it. However, i do see this error sometimes: log: Failed to load resource: net::ERR_FILE_NOT_FOUND -- it could be for a vendor asset we aren't using?

[jywarren]

Suggested change

	args: ['--no-sandbox','allow-sync-xhr-in-page-dismissal'],
	args: ['--no-sandbox', '--allow-sync-xhr-in-page-dismissal'],

[jywarren]

Yayyyyy!!!

[cesswairimu]

🎉🎉🎉🎉🎉